fix: Fix Foldable1 NonEmptyArray instance (requires https://github.com/purescript/purescript-nonempty/pull/39)
#183
Conversation
| @@ -1,6 +1,6 @@ | |||
| "use strict"; | |||
|
|
|||
| exports.fold1Impl = function (f) { | |||
| exports.foldr1Impl = function (f) { | |||
There was a problem hiding this comment.
Isn't this the implementation for foldl1?
There was a problem hiding this comment.
yes, I changed a name, because this name is better
There was a problem hiding this comment.
Let me clarify. The function name is foldr1Impl, but the implementation is what I would define for foldl1Impl. My issue isn't that the you changed the name. My issue is that the name refers to the wrong implementation. If you changed this to foldl1Impl and changed the currently named foldl1Impl to foldr1Impl, then the names would refer to the correct functions. You would also need to update the tests, since they are referring to the wrong outputs as well.
test/Test/Data/Array/NonEmpty.purs
Outdated
| assert $ foldr1 (\l r -> "(" <> l <> r <> ")") (fromArray ["a"]) == "a" | ||
|
|
||
| log "foldl1 should work" | ||
| assert $ foldl1 (\l r -> "(" <> l <> r <> ")") (fromArray ["a", "b", "c", "d"]) == "(a(b(cd)))" |
There was a problem hiding this comment.
Pretty sure this should be foldr1's test:
"( <> "a" <>
"(" <> "b" <>
"(" <> "c" <> "d" <> ")"
<> ")"
<> ")"
There was a problem hiding this comment.
indeed, tnx, but the innermost d is not wrapped
the test is taken from https://github.com/purescript/purescript-nonempty/pull/39/files
There was a problem hiding this comment.
Thanks! I updated my code.
|
Merged |
…